Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmoothStream track (format) label metadata is not made available #9252

Closed
rossbeazley opened this issue Aug 4, 2021 · 2 comments
Closed
Assignees
Labels

Comments

@rossbeazley
Copy link

rossbeazley commented Aug 4, 2021

This is a bug very similar to #1095

When parsing smooth streams, the label that can appear on StreamIndex is not propogated to associated Format objects. Inclusion of the label will make presenting choices of captions, subtitles or audio tracks nicer to the user.

This commit adds a failing test illustrating it and the fix is here.

Im currently trying to sort out access with our corporate CLA primary point of contact but its quite trivial and could just be transcribed if you wish. The PR is raised here.

@andrewlewis
Copy link
Collaborator

I'll take a look at submitting a simple fix directly and let you know if I run into any issues. Thanks!

@rossbeazley
Copy link
Author

👌

christosts pushed a commit that referenced this issue Aug 5, 2021
Issue: #9252

#minor-release

PiperOrigin-RevId: 388889406
@ojw28 ojw28 closed this as completed Aug 9, 2021
christosts pushed a commit that referenced this issue Aug 11, 2021
Issue: #9252

#minor-release

PiperOrigin-RevId: 388889406
@google google locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants