Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTSP session header parser can't parse timeout parameter #9416

Closed
ekindino opened this issue Sep 10, 2021 · 1 comment
Closed

RTSP session header parser can't parse timeout parameter #9416

ekindino opened this issue Sep 10, 2021 · 1 comment
Assignees
Labels

Comments

@ekindino
Copy link

The fix for the issue #9254 disregards the timeout parameter that mat be present in session descriptors.

The previous SESSION_HEADER_PATTERN regex was supposed to parse the ";timeout=X" part at the end which some devices use. The current regex returns the timeout parameter as a part of the session id causing a mismatch on the next request and the timeout parameter is not being parsed at all.

As an example "parseSessionHeader" function with the "headerValue" "45266830;timeout=5" returns "sessionId" as "45266830;timeout=5" and returns the default timeout. The session id should be "45266830" and the timeout value should be returned as 5.

@claincly
Copy link
Contributor

Able to repro, will be fixed soon.

ojw28 pushed a commit that referenced this issue Sep 10, 2021
Issue: #9416

The dash "-" in the brackets must be escaped, or it acts like a range operator.

#minor-release

PiperOrigin-RevId: 395909845
christosts pushed a commit that referenced this issue Sep 21, 2021
Issue: #9416

The dash "-" in the brackets must be escaped, or it acts like a range
operator.

PiperOrigin-RevId: 395909845
@google google locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants