Issue #10159 : DASH DTS Digital Surround Passthrough Fails in recent … #10214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecent Exoplayer Versions
ojw28
reviewed
Apr 25, 2022
There was a problem hiding this comment.
I've put a couple of comments inline for you to take a look at.
If my suggestions look good then there's no need for you to update the pull request. Just reply to confirm that they're equivalent, and I'll get the change merged.
If my suggestions look functionally different, then please let me know what's different about them :). Thanks!
...ash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java
Show resolved
Hide resolved
...ash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java
Show resolved
Hide resolved
marcbaechinger
pushed a commit
that referenced
this pull request
Jun 16, 2022
PiperOrigin-RevId: 444585404
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ojw28 Here is the pull request. Let me know if this is ok. Thanks.