Improve far seek performance of chunkSampleStream #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojw28
reviewed
Jan 13, 2017
| * Seeks to the specified position in microseconds. | ||
| * | ||
| * @param positionUs The seek position in microseconds. | ||
| */ | ||
| public void seekToUs(long positionUs) { | ||
| lastSeekPositionUs = positionUs; | ||
| // If we're not pending a reset, see if we can seek within the sample queue. | ||
| boolean seekInsideBuffer = !isPendingReset() && sampleQueue.skipToKeyframeBefore(positionUs); | ||
| boolean seekInsideBuffer = !isPendingReset() && | ||
| sampleQueue.skipToKeyframeBefore(positionUs, isWithinLastChunk(positionUs)); |
There was a problem hiding this comment.
I'm not sure you need to be as sophisticated as checking whether the position is within the last chunk. Isn't it sufficient just to pass positionUs < getNextLoadPositionUs() as the second argument? I don't think passing true does any harm in cases where positionUs is earlier than the last chunk.
This allows you to remove your isWithinLastChunk and getCurrentLoadPosition methods ;).
| * @return Whether the skip was successful. | ||
| */ | ||
| public boolean skipToKeyframeBefore(long timeUs) { | ||
| long nextOffset = infoQueue.skipToKeyframeBefore(timeUs); | ||
| long nextOffset = infoQueue.skipToKeyframeBefore(timeUs, false); |
There was a problem hiding this comment.
You can replace the whole body of this method with just:
return skipToKeyframeBefore(timeUs, false)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework to make the patch accordingly by @ojw28 kindly suggestions #as #2247.
Issue report: #2253