Increase minimum tvOS version to match GTMSessionFetcherCore #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gtm-session-fetcher requires tvOS v10 or higher. |
mdmathias
force-pushed
the
mdmathias/fix-nightly-build
branch
from
903e476
to
497d663
Compare
|
Running our build action on this branch verifies that this change fixes the failure. |
|
Would love to get this in ASAP, it's affecting my builds as well. Would also need to bump the iOS version to 10. |
|
@mdmathias did you mean to leave this as a draft? Maybe we should address the tvOS mismatch with the upcoming 2.0 release as impact is limited. @Innocuousjoe I believe your issue was addressed in google/GoogleSignIn-iOS#252 and wasn't tvOS specific. |
|
@petea this is ready for review. |
petea
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.