Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot access fetcherAuthorizer property on GIDAuthentication from swift #106

Closed
lilpit opened this issue Mar 10, 2022 · 1 comment · Fixed by #107
Closed

Cannot access fetcherAuthorizer property on GIDAuthentication from swift #106

lilpit opened this issue Mar 10, 2022 · 1 comment · Fixed by #107
Assignees
@mdmathias
Labels
bug Something isn't working Swift
Milestone
6.2.0

Comments

@lilpit
Copy link

lilpit commented Mar 10, 2022

The fetcherAuthorizer method signature is not visible in swift generated interface of GIDAuthentication .
This prevent the use of this library to work with https://github.com/google/google-api-objectivec-client-for-rest from swift
Screenshot 2022-03-10 at 15 08 22
@petea petea added bug Something isn't working Swift labels Mar 10, 2022
@mdmathias mdmathias mentioned this issue Mar 10, 2022
Merged
@petea petea added this to the 6.2.0 milestone Mar 10, 2022
mdmathias added a commit that referenced this issue Mar 10, 2022
@mdmathias
Import GTMFetcherAuthorizationProtocol in GIDAuthentication to expose…
d7f31ee 
… to Swift

Forward declaring the protocol in GIDAuthentication led to a method vending a
GTMFetcherAuthorizationProtocol conforming instance to not be visible in Swift.

Fixes #106.
@petea
Copy link
Contributor

petea commented Mar 10, 2022

@lilpit thanks for spotting this, we'll have a fix in the next release.

mdmathias added a commit that referenced this issue Mar 10, 2022
@mdmathias
Import GTMFetcherAuthorizationProtocol in GIDAuthentication to expose…
5785a01 
… to Swift (#107)

Forward declaring the protocol in GIDAuthentication led to a method vending a
GTMFetcherAuthorizationProtocol conforming instance to not be visible in Swift.

Fixes #106.
Alex-4-Git pushed a commit that referenced this issue Mar 16, 2022
@mdmathias @Alex-4-Git
Import GTMFetcherAuthorizationProtocol in GIDAuthentication to expose…
49c84f7 
… to Swift (#107)

Forward declaring the protocol in GIDAuthentication led to a method vending a
GTMFetcherAuthorizationProtocol conforming instance to not be visible in Swift.

Fixes #106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdmathias mdmathias

Labels
bug Something isn't working Swift
Projects
None yet
Milestone
6.2.0
Development

Successfully merging a pull request may close this issue.

Import GTMFetcherAuthorizationProtocol in GIDAuthentication google/GoogleSignIn-iOS
3 participants
@petea @lilpit @mdmathias