Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Fix flaky 'NSURLSession+GULPromises' test #119

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Aug 6, 2023

A couple observations while trying to reproduce.

  • The test fails in what appears to be random fashion. When it fails, it's due to an uncaught exception. I'm not sure where it's coming from but I suspect it may be OCMock related... not sure
  • It seems like disabling xcpretty in the invocation increases the chance of it crashing
  • It is not reproducible in Xcode
  • invocation: ../firebase-ios-sdk/scripts/test_catalyst.sh GoogleUtilities test GoogleUtilities-Unit-unit

CI is green though I'm not super convinced this will work. See #120 for alt. approach that does some code cleanup.

@google-oss-bot
Copy link

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 25, 2024

I think this may be worth merging. I had a much better solution that ended up not working out in #120, so I'd like to pick from there at some point. In the meantime, an extended timeout period will hopefully reduce some flakes.

@ncooke3 ncooke3 merged commit a94da69 into main Apr 25, 2024
20 checks passed
@ncooke3 ncooke3 deleted the nc/flaky-tests branch April 25, 2024 16:06
@paulb777
Copy link
Member

Looks like this test is still failing every night in the catalyst job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants