Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fixes now that default runners can be arm64 #151

Merged
merged 2 commits into from
Apr 25, 2024
Merged

CI fixes now that default runners can be arm64 #151

merged 2 commits into from
Apr 25, 2024

Conversation

paulb777
Copy link
Member

  • Update default CocoaPods version
  • Fix unreachable warning in test build
  • Fix device check

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • GoogleUtilities-ios-unit-GoogleUtilities.framework

    Overall coverage changed from 0.62% (8e5d57e) to 0.62% (6544915) by +0.00%.

    FilenameBase (8e5d57e)Merge (6544915)Diff
    GULAppEnvironmentUtil.m3.14%3.23%+0.08%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7XbcYYL5sS.html

ncooke3
ncooke3 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The catalyst flakes are very likely a flake.

andrewheard
andrewheard approved these changes Apr 25, 2024
View reviewed changes
SwiftPMTests/swift-test/main.swift
Comment on lines +44 to +45
let device = GULAppEnvironmentUtil.deviceModel()
XCTAssertTrue(device == "x86_64" || device == "arm64")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Will help with local testing too!

@paulb777 paulb777 merged commit 73bc572 into main Apr 25, 2024
19 of 20 checks passed
@paulb777 paulb777 deleted the pb-arm-ci-fixes branch April 25, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulb777 @google-oss-bot @andrewheard @ncooke3