-
Notifications
You must be signed in to change notification settings - Fork 286
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes and moves the SHA256 busy check (#689)
Inside `libraries/opensk`, we want to preserve the property that there are never two SHA256 hashes calculates in parallel. This is useful to support hardware crypto that can't swap out its state. To check this property, there was an assertion in `libraries/crypto`. However, the assertion - didn't work, - should have been in opensk instead - and should run in tests, but not when deployed. Since Rust runs tests in parallel, this PR makes sure that the assertion only fails if two SHA256 are calculated within one thread. Fixes #688
- Loading branch information
1 parent
8a0ee9d
commit 19063c4
Showing
3 changed files
with
49 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters