Added pypi:testresources required by one of the tockloader dependencies; #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution to make OpenSK work on more platforms! |
kaczmarczyck
previously approved these changes
Sep 10, 2021
Signed-off-by: minjun <xi.minjun@gmail.com>
kaczmarczyck
force-pushed
the
bugfix
branch
from
9b71057
to
f908988
Compare
kaczmarczyck
approved these changes
Sep 10, 2021
|
I went ahead and rebased, to see if it works :) |
kaczmarczyck
pushed a commit
to kaczmarczyck/OpenSK
that referenced
this pull request
Nov 19, 2021
…es; (google#376) Signed-off-by: minjun <xi.minjun@gmail.com>
kaczmarczyck
pushed a commit
that referenced
this pull request
Nov 19, 2021
…es; (#376) Signed-off-by: minjun <xi.minjun@gmail.com>
kaczmarczyck
pushed a commit
to kaczmarczyck/OpenSK
that referenced
this pull request
Aug 23, 2022
…es; (google#376) Signed-off-by: minjun <xi.minjun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: minjun xi.minjun@gmail.com
Fixes #343
Running
setup.shon ubuntu versions (at least 20.04, 20.10), there will be one unmet dependency error message, indicating "launchpadlib" requires "testresources".The pypi package "testresources" requires to be installed, but it doesn't.
The solution is easy here: install testresouces pypi package, before installing "tockloader", "intelhex", etc.