Parse slot_id in use from token state #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support switching to multi-PIN feature and making the default slots 8. But the command to switch to multi-PIN isn't exposed yet because the implementation isn't ready. Main change of this commit is to cache the slot_id in use inside token state, and retrieve it from token state when needed.
hcyang-google
force-pushed
the
multi-pin
branch
2 times, most recently
from
a863f6d
to
acf8c4a
Compare
kaczmarczyck
approved these changes
Sep 21, 2022
ia0
reviewed
Sep 21, 2022
* fixed version of once_cell * fixes comments * removes unnecessary fuzz dependency
hcyang-google
force-pushed
the
multi-pin
branch
from
acf8c4a
to
2d2f591
Compare
kaczmarczyck
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support switching to multi-PIN feature and making the default slots 8. But the command to switch to multi-PIN isn't exposed yet because the implementation isn't ready.
Main change of this commit is to cache the slot_id in use inside token state, and retrieve it from token state when needed.
I was thinking about unittest when I added more code and opened up the multi-PIN feature, and I will focus on the following types of unittests: