Skip to content

Commit

Permalink
Enable /Zc:strictStrings in debug builds
Browse files Browse the repository at this point in the history 
VS 2013's header files had a bug in their overloaded operator new which
prevented using /Zc:strictStrings in debug builds - operator new took a
char* instead of a const char*. This appears to have been fixed in VS
2015 so now I can and have enabled /Zc:strictStrings in debug builds, to
catch careless errors ever so slightly earlier.

mshtml.h and wbemdisp.h are still incompatible with Zc:strictStrings.
They are bad and they should feel bad.
  • Loading branch information
@randomascii
randomascii committed Oct 26, 2016
1 parent 2f4db8c commit d361ca9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions UIforETW/UIforETW.vcxproj
View file
Expand Up @@ -110,7 +110,7 @@
<TreatWarningAsError>true</TreatWarningAsError>
<AdditionalIncludeDirectories>..\include</AdditionalIncludeDirectories>
<EnablePREfast>false</EnablePREfast>
<AdditionalOptions>/Gw</AdditionalOptions>
<AdditionalOptions>/Gw /Zc:strictStrings</AdditionalOptions>
</ClCompile>
<Link>
<SubSystem>Windows</SubSystem>
Expand Down Expand Up @@ -145,7 +145,7 @@
<TreatWarningAsError>true</TreatWarningAsError>
<AdditionalIncludeDirectories>..\include</AdditionalIncludeDirectories>
<EnablePREfast>false</EnablePREfast>
<AdditionalOptions>/Gw</AdditionalOptions>
<AdditionalOptions>/Gw /Zc:strictStrings</AdditionalOptions>
</ClCompile>
<Link>
<SubSystem>Windows</SubSystem>
Expand Down

1 comment on commit d361ca9

@mwinterb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an irrelevant note, thanks for reporting this on Connect. Maybe the combined weight of Bruce Dawson + Chrome can help get these midlc issues finally addressed, in a satisfactory way :)

Please sign in to comment.