Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Page title should be "Web Fundamentals - Google Developers" #379

Closed
maxh opened this issue Jun 5, 2014 · 8 comments
Closed

Page title should be "Web Fundamentals - Google Developers" #379

maxh opened this issue Jun 5, 2014 · 8 comments

Comments

@maxh
Copy link
Contributor

maxh commented Jun 5, 2014

Right now it's "Web Fundamentals - Web Fundamentals"

image

@PaulKinlan
Copy link
Contributor

Urgh.. I'll get this sorted, there is something up with the template.

On 5 June 2014 03:47, Max Heinritz notifications@github.com wrote:

Right now it's "Web Fundamentals - Web Fundamentals"

[image: image]
https://cloud.githubusercontent.com/assets/1289501/3182858/b2fe47d4-ec5b-11e3-912e-5340f409f064.png


Reply to this email directly or view it on GitHub
#379.

@PaulKinlan
Copy link
Contributor

We also said that we are not going to put Google Developers in the title at all because search sometimes adds that in....

Happy to change it, but there was a process of our logic that lead up to this (excluding the error)

@maxh
Copy link
Contributor Author

maxh commented Jun 5, 2014

I see, sorry for confusion. I didn't fully understand the relationship
between the two. I think ideally:

  1. The webpage title would be "Web Fundamentals -- Google Developers"
  2. The title on the search results page would be "Web Fundamentals --
    Google Developers"

#2 is higher priority IMO than #1.

On Thu, Jun 5, 2014 at 2:39 AM, Paul Kinlan notifications@github.com
wrote:

Closed #379 #379 via
25c7c67
25c7c67
.


Reply to this email directly or view it on GitHub
#379 (comment).

@PaulKinlan
Copy link
Contributor

I have updated it so that 1 and 2 apply. search for the main homepage
takes this title as its title in the results

On 5 June 2014 17:13, Max Heinritz notifications@github.com wrote:

I see, sorry for confusion. I didn't fully understand the relationship
between the two. I think ideally:

  1. The webpage title would be "Web Fundamentals -- Google Developers"
  2. The title on the search results page would be "Web Fundamentals --
    Google Developers"

#2 is higher priority IMO than #1.

On Thu, Jun 5, 2014 at 2:39 AM, Paul Kinlan notifications@github.com
wrote:

Closed #379 #379 via
25c7c67
<
25c7c676fc04b1bfbf464e14dde75df94626f640>

.


Reply to this email directly or view it on GitHub
#379 (comment).


Reply to this email directly or view it on GitHub
#379 (comment)
.

@maxh
Copy link
Contributor Author

maxh commented Jun 10, 2014

Just saw this in Google search:

image

When are the changes expected to be live?

@maxh maxh reopened this Jun 10, 2014
@PaulKinlan
Copy link
Contributor

Can you check this on the staging site as that is where it was defiantly
fixed.
On 10 Jun 2014 23:25, "Max Heinritz" notifications@github.com wrote:

Reopened #379 #379.


Reply to this email directly or view it on GitHub
#379 (comment).

@maxh
Copy link
Contributor Author

maxh commented Jun 11, 2014

Looks good on https://web-central.appspot.com/web/fundamentals/

I guess the question is whether to mark it fixed when the change is in staging or when it reaches Stable.

Happy to mark as fixed now.

@maxh maxh closed this as completed Jun 11, 2014
@PaulKinlan
Copy link
Contributor

I have been marking things as fixed on staging.

On 11 June 2014 17:47, Max Heinritz notifications@github.com wrote:

Closed #379 #379.


Reply to this email directly or view it on GitHub
#379 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants