-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other - can you see about shrinking the size of src/content/en/updates/images/2017/10/push-result.png
it's 600KB+
@@ -4,7 +4,7 @@ description: New features and changes coming to DevTools in Chrome 59. | |||
|
|||
{# wf_updated_on: 2017-04-19 #} | |||
{# wf_published_on: 2017-04-12 #} | |||
{# wf_tags: chrome59,devtools #} | |||
{# wf_tags: chrome59,devtools,devtools-whatsnew #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add devtools-whatsnew
to src/data/commonTags.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Done: Images compressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with comments.
</iframe> | ||
</div> | ||
|
||
As of Chrome 63, this problem is no more. DevTools now supports multiple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit - suggestion to lean this a little: "As of Chrome 63, DevTools now..." (remove this problem is no more and bring together two sentences).
|
||
## Workspaces 2.0 {: #workspaces } | ||
|
||
Workspaces have been around for some time in DevTools. This feature enables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to Workspaces docs at the start of where you mention they've been around.
within DevTools, and the changes persist to the local version of your | ||
project on your file system. | ||
|
||
Workspaces 2.0 builds off of 1.0, adding a more helpful UX and improved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment that this section is a bit 'thisy'. Suggestion to remove some of the thises.
|
||
Workspaces 2.0 builds off of 1.0, adding a more helpful UX and improved | ||
auto-mapping of transpiled code. | ||
This feature was originally scheduled to be released shortly after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to explain how the feature shifted in being released? It is somewhat distracting from the feature. Suggestion to delete this sentence, which would lean the text, and get rid of 'thisiness'.
</iframe> | ||
</div> | ||
|
||
## Simulate push notifications with custom data {: #push } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this feature is sweet!
Simulating push notifications has been around for a while in DevTools, | ||
with one limitation: you couldn't send custom data. But with | ||
the new **Push** text box coming to the **Service Worker** pane in Chrome 63, | ||
now you can. Try it now: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads a little funny. Following a similar style to background sync events below, how about something like this:
"Simulating push notifications has been around for awhile in DevTools, but you couldn't send custom data. The new push text box coming to the Service Worker pane in Chrome 63 lets you write something in a text box and send it as custom data:"
</div> | ||
|
||
As of Chrome 63, this problem is no more. DevTools now supports multiple | ||
remote debugging clients. Watch the video below to see an example of VS Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more usecases that work now:
- A DevTools Protocol client connected to the
--remote-debugging-port
websocket (e.g. chrome-remote-interface) and an open DevTools window- chromedriver/selenium plus DevTools
- vscode-chrome-debug or WebStorm Chrome Debugging plus DevTools
- Lighthouse or Puppeteer plus DevTools
- Two websocket protocol clients at once. (Two puppeteer sessions connecting to the same tab)
chrome.debugger
extension API plus DevTools- Two different chrome extensions both using
chrome.debugger
Unrelated but powerful together: chrome.debugger
is now available from within a devtools extension's devtools_page
. (New as of like 6mo ago)
I'd love to have the above usecases included in this blog post.
Also we might as well call out this was devtools #1 bug and chromium's #3 bug: https://bugs.chromium.org/p/chromium/issues/detail?id=129539
@paulirish I mentioned the bugs and use cases in my latest commit. didn't mention the |
Dismissing Paul's and Pete's reviews to get this landed before branch point and make sure that the devtools UI integration is OK. I think I handled all of their feedback anyway. I can subsequently update the post if needed. |
feedback addressed
I can iterate on this post, just need to land a basic draft by m63 branch point (Oct 12)