Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

[devtools] add WNDT63, and tags #5132

Merged
merged 4 commits into from
Oct 11, 2017
Merged

[devtools] add WNDT63, and tags #5132

merged 4 commits into from
Oct 11, 2017

Conversation

kaycebasques
Copy link
Contributor

I can iterate on this post, just need to land a basic draft by m63 branch point (Oct 12)

petele
petele previously requested changes Oct 11, 2017
Copy link
Member

@petele petele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other - can you see about shrinking the size of src/content/en/updates/images/2017/10/push-result.png it's 600KB+

@@ -4,7 +4,7 @@ description: New features and changes coming to DevTools in Chrome 59.

{# wf_updated_on: 2017-04-19 #}
{# wf_published_on: 2017-04-12 #}
{# wf_tags: chrome59,devtools #}
{# wf_tags: chrome59,devtools,devtools-whatsnew #}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add devtools-whatsnew to src/data/commonTags.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kaycebasques
Copy link
Contributor Author

Done: Images compressed

Copy link
Contributor

@Meggin Meggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with comments.

</iframe>
</div>

As of Chrome 63, this problem is no more. DevTools now supports multiple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit - suggestion to lean this a little: "As of Chrome 63, DevTools now..." (remove this problem is no more and bring together two sentences).


## Workspaces 2.0 {: #workspaces }

Workspaces have been around for some time in DevTools. This feature enables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to Workspaces docs at the start of where you mention they've been around.

within DevTools, and the changes persist to the local version of your
project on your file system.

Workspaces 2.0 builds off of 1.0, adding a more helpful UX and improved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment that this section is a bit 'thisy'. Suggestion to remove some of the thises.


Workspaces 2.0 builds off of 1.0, adding a more helpful UX and improved
auto-mapping of transpiled code.
This feature was originally scheduled to be released shortly after
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to explain how the feature shifted in being released? It is somewhat distracting from the feature. Suggestion to delete this sentence, which would lean the text, and get rid of 'thisiness'.

</iframe>
</div>

## Simulate push notifications with custom data {: #push }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this feature is sweet!

Simulating push notifications has been around for a while in DevTools,
with one limitation: you couldn't send custom data. But with
the new **Push** text box coming to the **Service Worker** pane in Chrome 63,
now you can. Try it now:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads a little funny. Following a similar style to background sync events below, how about something like this:

"Simulating push notifications has been around for awhile in DevTools, but you couldn't send custom data. The new push text box coming to the Service Worker pane in Chrome 63 lets you write something in a text box and send it as custom data:"

</div>

As of Chrome 63, this problem is no more. DevTools now supports multiple
remote debugging clients. Watch the video below to see an example of VS Code
Copy link
Member

@paulirish paulirish Oct 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more usecases that work now:

  • A DevTools Protocol client connected to the --remote-debugging-port websocket (e.g. chrome-remote-interface) and an open DevTools window
    • chromedriver/selenium plus DevTools
    • vscode-chrome-debug or WebStorm Chrome Debugging plus DevTools
    • Lighthouse or Puppeteer plus DevTools
  • Two websocket protocol clients at once. (Two puppeteer sessions connecting to the same tab)
  • chrome.debugger extension API plus DevTools
  • Two different chrome extensions both using chrome.debugger

Unrelated but powerful together: chrome.debugger is now available from within a devtools extension's devtools_page. (New as of like 6mo ago)


I'd love to have the above usecases included in this blog post.

Also we might as well call out this was devtools #1 bug and chromium's #3 bug: https://bugs.chromium.org/p/chromium/issues/detail?id=129539

@kaycebasques kaycebasques mentioned this pull request Oct 11, 2017
6 tasks
@kaycebasques
Copy link
Contributor Author

@paulirish I mentioned the bugs and use cases in my latest commit. didn't mention the chrome.debugger being available from devtools extensions, though, because I couldn't make it relevant to the multi-client story

@kaycebasques
Copy link
Contributor Author

kaycebasques commented Oct 11, 2017

Dismissing Paul's and Pete's reviews to get this landed before branch point and make sure that the devtools UI integration is OK. I think I handled all of their feedback anyway. I can subsequently update the post if needed.

@kaycebasques kaycebasques dismissed stale reviews from petele and paulirish October 11, 2017 19:59

feedback addressed

@kaycebasques kaycebasques merged commit 691f4c3 into google:master Oct 11, 2017
@kaycebasques kaycebasques added this to Done in DevTools Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
DevTools
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants