Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Fix broken button in 'Get Started With The Console' tutorial #6646

Merged
merged 1 commit into from Dec 4, 2018

Conversation

ollelauribostrom
Copy link
Contributor

What's changed, or what was fixed?

  • Fix broken "Log Numbers" button by removing {% verbatim %} & {% endverbatim %} tags
  • Closing all <img> tags

Fixes: #6574

  • This has been reviewed and approved by (NAME)
  • I have run npm test locally and all tests pass.
  • I have added the appropriate type-something label.
  • I've staged the site and manually verified that my content displays correctly.

CC: @petele

@@ -208,9 +208,6 @@ filter the **Console** to only show messages that you care about.
filtering.

{% framebox width="auto" height="auto" enable_widgets="true" %}

{% verbatim %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaycebasques - can you confirm that these should be removed? They are showing up on the live page, which I don't think is what you want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a reason I did this, but obviously it's not working as intended. So let's go for it...

@petele
Copy link
Member

petele commented Oct 15, 2018

@kaycebasques - can you review/merge please.

@petele
Copy link
Member

petele commented Nov 27, 2018

@kaycebasques - any updates on this?

@kaycebasques
Copy link
Contributor

@petele checking it out now...

Copy link
Contributor

@kaycebasques kaycebasques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ollelauribostrom!

@@ -16,7 +16,7 @@ This tutorial teaches you how to use the **Console** in Chrome DevTools.

<figure>
<img src="/web/tools/chrome-devtools/images/panels/console.png"
alt="The Console."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops...

@@ -208,9 +208,6 @@ filter the **Console** to only show messages that you care about.
filtering.

{% framebox width="auto" height="auto" enable_widgets="true" %}

{% verbatim %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a reason I did this, but obviously it's not working as intended. So let's go for it...

@kaycebasques kaycebasques merged commit 979ab9d into google:master Dec 4, 2018
@WebFundBot
Copy link

🎉 This has been pushed live to https://developers.google.com/web/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants