Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

LitElement & lit-html release update #7200

Merged
merged 4 commits into from
Feb 5, 2019
Merged

Conversation

arthurevans
Copy link
Contributor

@arthurevans arthurevans commented Feb 5, 2019

What's changed, or what was fixed?
It's a new update! For lit-html and LitElement!

Target Live Date: 2019-02-05

Trying to coordinate several items for release, please don't push this live without me.

  • This has been reviewed and approved by @kaycebasques
  • I have run npm test locally and all tests pass.
  • I have added the appropriate type-something label.
  • I've staged the site and manually verified that my content displays correctly.

Q: What the heck is a type-something label?

CC: @petele

@arthurevans
Copy link
Contributor Author

Warning #1 is the word "nodes" and is not a typo for Node.

Warning #2 should be fixed now...

@arthurevans
Copy link
Contributor Author

#1, as explained before, not a typo.
#2, Material Design matches the usage in the devsite style guide & the Material Design site so not sure why it's wrong. I think this guidance might have changed at some point ...

@WebFundBot
Copy link

Whoops!

There were 2 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

WARNINGS
src/content/en/updates/2019/02/lit-element-and-lit-html.md#L61 - Common typo found: 'node' Should it be 'Node'?
src/content/en/updates/2019/02/lit-element-and-lit-html.md#L113 - Common typo found: 'Material Design' Should it be 'material design'?

@rictic
Copy link
Member

rictic commented Feb 5, 2019

type-something is probably a set of PR labels in GitHub?

@kaycebasques
Copy link
Contributor

LGTM

@kaycebasques kaycebasques merged commit db52811 into master Feb 5, 2019
@kaycebasques kaycebasques deleted the lit-element-release branch February 5, 2019 21:30
@arthurevans
Copy link
Contributor Author

Thanks @kaycebasques !

@WebFundBot
Copy link

🎉 This has been pushed live to https://developers.google.com/web/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants