Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

What's New In DevTools (Chrome 82) #8548

Merged
merged 10 commits into from
Mar 11, 2020
Merged

What's New In DevTools (Chrome 82) #8548

merged 10 commits into from
Mar 11, 2020

Conversation

kaycebasques
Copy link
Contributor

@kaycebasques kaycebasques commented Mar 10, 2020

Target Live Date: 2020-03-12

  • This has been reviewed and approved by @kaycebasques
  • I have run npm test locally and all tests pass.
  • I have added the appropriate type-something label.
  • I've staged the site and manually verified that my content displays correctly.


{# https://chromium.googlesource.com/devtools/devtools-frontend/+/e847a020093fbd3c367eda02a7008feae5e28641 #}

Send feedback to [Chromium issue #1003700](https://crbug.com/1003700).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the line


Send feedback to [Chromium issue #1054447](https://crbug.com/1054447).

## `$$` now returns elements across shadow DOM boundaries {: #querySelectorAll }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed. It doesn’t affect the DevTools Console $$, but rather the helper with the same name which we use in the e2e tests. cc @paullewis @TimvdLippe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes more sense! I was like "why is Tim talking as if this is a new feature? Pretty sure we've had $$ forever..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this section


* [CLS](https://github.com/GoogleChrome/lighthouse/commit/a8a0f8fd369faaa23b97d8803bfc220db31e4769#diff-eb7e207cabf22c8000b5abe8f18c6daf)
* [Legacy JS](https://github.com/GoogleChrome/lighthouse/pull/10303)
* [Maskable icon](https://github.com/GoogleChrome/lighthouse/pull/10370)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the earlier DevTools release notes with maskable icon support to reference the newly added Lighthouse support?

Actually, I just realized that the maskable icon feature in DevTools wasn’t included in the M81 release notes. @kaycebasques could you please add this? We already have feature documentation here so you could probably re-use some text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually can't even see any of these new audits: #8548 (comment)

I can mention the maskable audit feature from m81 in these release notes and just say "we missed this in m81 but are covering it now"... that way it gets more awareness. There will be a few people who say "why are you covering something from m81 in m82?" but the increased overall awareness is worth making a few people annoyed/confused IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maskable icons section added

@kaycebasques kaycebasques changed the title Create What's New In DevTools (Chrome 82) What's New In DevTools (Chrome 82) Mar 10, 2020
@kaycebasques
Copy link
Contributor Author

@connorjclark & @paulirish my Canary is running 5.7.1:

Screen Shot 2020-03-10 at 6 05 42 PM

But I'm not seeing the CLS metric, the duplicate JS audit, the legacy JS audit, or the maskable icon audit. Are these hidden or is there something fishy going on?

Screen Shot 2020-03-10 at 6 06 04 PM

Screen Shot 2020-03-10 at 6 06 21 PM

Screen Shot 2020-03-10 at 6 06 43 PM

@connorjclark
Copy link
Contributor

All of those new audits will be in 6.0, which is unreleased.

@kaycebasques
Copy link
Contributor Author

@mathiasbynens vision deficiencies section was rephrased, description of each was added, reference to restricted issue was removed

* Tritanopia. The inability to perceive blue light.
* Tritanomaly. A reduced sensitivity to blue light (extremely rare).
* Achromatopsia. The inability to perceive any color except for shades of grey (extremely rare).
* Achromatomaly. A reduced sensitivity to green, red, and blue light (extremely rare).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably point out that the -ia forms are the (rare) extreme versions of the forms ending in -omaly, and that every person with an -omaly vision deficiency is different and might see things differently (being able to perceive a bit more/less of the relevant colors). These simulations are just to give you a visual approximation of how someone might experience this — and although the approximation should be good enough for you to identify and resolve issues, there’s no way to simulate exactly what a given person would experience.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is based on Twitter feedback)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


Android Oreo introduced adaptive icons, which display app icons in a variety
of shapes across different device models. [Maskable icons](https://web.dev/maskable-icon/)
are a new icon format that support adaptive icons, which will enable you to ensure that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
are a new icon format that support adaptive icons, which will enable you to ensure that
are a new icon format that support adaptive icons, which enable you to ensure that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (in upcoming commit)

your [PWA](https://web.dev/progressive-web-apps) icon looks good on Android Oreo devices.

Enable the new **Show only the minimum safe area for maskable icons** checkbox in the
**Manifest** pane to check that your maskable icon will look good on Android Oreo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe “on devices that support the maskable icons standard, such as Android Oreo devices”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (in upcoming commit)

@WebFundBot
Copy link

Whoops!

There were 18 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

WARNINGS
src/content/en/updates/2020/03/devtools.md#L152 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/updates/2020/03/devtools.md#L31 - Common typo found: 'colour' Should it be 'color'? Please use American spellings. See: https://developers.google.com/style/spelling
src/content/en/updates/2020/03/devtools.md#L31 - Common typo found: 'colour' Should it be 'color'? Please use American spellings. See: https://developers.google.com/style/spelling
src/content/en/updates/2020/03/devtools.md#L31 - Common typo found: 'colour' Should it be 'color'? Please use American spellings. See: https://developers.google.com/style/spelling
src/content/en/updates/2020/03/devtools.md#L60 - Line must be at most 100 characters
src/content/en/updates/2020/03/devtools.md#L96 - Line must be at most 100 characters
src/content/en/updates/2020/03/devtools.md#L121 - Line must be at most 100 characters
src/content/en/updates/2020/03/devtools.md#L145 - Line must be at most 100 characters
src/content/en/updates/_shared/discover.md#L243 - Consider adding a "was this page helpful?" widget to your page: https://developers.google.com/web/resources/widgets#helpful
src/content/en/updates/_shared/discover.md#L89 - Common typo found: 'node' Should it be 'Node'?
src/content/en/updates/_shared/discover.md#L114 - Common typo found: 'node' Should it be 'Node'?
src/content/en/updates/_shared/discover.md#L115 - Common typo found: 'node' Should it be 'Node'?
src/content/en/updates/_shared/discover.md#L122 - Common typo found: 'node' Should it be 'Node'?
src/content/en/updates/_shared/discover.md#L123 - Common typo found: 'node' Should it be 'Node'?
src/content/en/updates/_shared/discover.md#L127 - Common typo found: 'node' Should it be 'Node'?
src/content/en/updates/_shared/discover.md#L133 - Common typo found: 'node' Should it be 'Node'?
src/content/en/updates/_shared/discover.md#L133 - Common typo found: 'node' Should it be 'Node'?
src/content/en/updates/_shared/discover.md#L97 - Line must be at most 100 characters

@kaycebasques
Copy link
Contributor Author

Should be good enough for now. Need to land and publish before branch. We can always iterate from here with subsequent PRs.

@kaycebasques kaycebasques merged commit 22f5760 into master Mar 11, 2020
DevTools automation moved this from To Do to Done Mar 11, 2020
@petele petele deleted the wndt82 branch April 23, 2020 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
DevTools
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants