-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
|
||
{# https://chromium.googlesource.com/devtools/devtools-frontend/+/e847a020093fbd3c367eda02a7008feae5e28641 #} | ||
|
||
Send feedback to [Chromium issue #1003700](https://crbug.com/1003700). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
- This is currently a Google-only issue (not sure why though). We should either make it public or remove this line.
- Comment Font size of 13px combined with font weight of 300 is difficult to read #19 in the issue (by @hashseed) has some TODOs for the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the line
|
||
Send feedback to [Chromium issue #1054447](https://crbug.com/1054447). | ||
|
||
## `$$` now returns elements across shadow DOM boundaries {: #querySelectorAll } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed. It doesn’t affect the DevTools Console $$
, but rather the helper with the same name which we use in the e2e tests. cc @paullewis @TimvdLippe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes more sense! I was like "why is Tim talking as if this is a new feature? Pretty sure we've had $$
forever..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this section
|
||
* [CLS](https://github.com/GoogleChrome/lighthouse/commit/a8a0f8fd369faaa23b97d8803bfc220db31e4769#diff-eb7e207cabf22c8000b5abe8f18c6daf) | ||
* [Legacy JS](https://github.com/GoogleChrome/lighthouse/pull/10303) | ||
* [Maskable icon](https://github.com/GoogleChrome/lighthouse/pull/10370) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the earlier DevTools release notes with maskable icon support to reference the newly added Lighthouse support?
Actually, I just realized that the maskable icon feature in DevTools wasn’t included in the M81 release notes. @kaycebasques could you please add this? We already have feature documentation here so you could probably re-use some text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually can't even see any of these new audits: #8548 (comment)
I can mention the maskable audit feature from m81 in these release notes and just say "we missed this in m81 but are covering it now"... that way it gets more awareness. There will be a few people who say "why are you covering something from m81 in m82?" but the increased overall awareness is worth making a few people annoyed/confused IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maskable icons section added
@connorjclark & @paulirish my Canary is running 5.7.1: But I'm not seeing the CLS metric, the duplicate JS audit, the legacy JS audit, or the maskable icon audit. Are these hidden or is there something fishy going on? |
All of those new audits will be in 6.0, which is unreleased. |
@mathiasbynens vision deficiencies section was rephrased, description of each was added, reference to restricted issue was removed |
* Tritanopia. The inability to perceive blue light. | ||
* Tritanomaly. A reduced sensitivity to blue light (extremely rare). | ||
* Achromatopsia. The inability to perceive any color except for shades of grey (extremely rare). | ||
* Achromatomaly. A reduced sensitivity to green, red, and blue light (extremely rare). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably point out that the -ia
forms are the (rare) extreme versions of the forms ending in -omaly
, and that every person with an -omaly
vision deficiency is different and might see things differently (being able to perceive a bit more/less of the relevant colors). These simulations are just to give you a visual approximation of how someone might experience this — and although the approximation should be good enough for you to identify and resolve issues, there’s no way to simulate exactly what a given person would experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is based on Twitter feedback)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
Android Oreo introduced adaptive icons, which display app icons in a variety | ||
of shapes across different device models. [Maskable icons](https://web.dev/maskable-icon/) | ||
are a new icon format that support adaptive icons, which will enable you to ensure that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are a new icon format that support adaptive icons, which will enable you to ensure that | |
are a new icon format that support adaptive icons, which enable you to ensure that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (in upcoming commit)
your [PWA](https://web.dev/progressive-web-apps) icon looks good on Android Oreo devices. | ||
|
||
Enable the new **Show only the minimum safe area for maskable icons** checkbox in the | ||
**Manifest** pane to check that your maskable icon will look good on Android Oreo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe “on devices that support the maskable icons standard, such as Android Oreo devices”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (in upcoming commit)
Whoops! There were 18 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed. WARNINGS |
Should be good enough for now. Need to land and publish before branch. We can always iterate from here with subsequent PRs. |
Target Live Date: 2020-03-12
npm test
locally and all tests pass.type-something
label.