Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Update Workbox getting started docs #9093

Merged
merged 4 commits into from Nov 2, 2020
Merged

Update Workbox getting started docs #9093

merged 4 commits into from Nov 2, 2020

Conversation

Snugug
Copy link
Contributor

@Snugug Snugug commented Nov 2, 2020 •
edited

What's changed, or what was fixed?

  • Updates Workbox's getting started documentation

Target Live Date: 2020-11-03

  • This has been reviewed and approved by @jeffposnick
  • I have run npm test locally and all tests pass.
  • I have added the appropriate type-something label. (don't have the ability to add a label)
  • I've staged the site and manually verified that my content displays correctly. (unable to get local server working, don't know how to stage the site otherwise)

CC: @petele

@google-cla google-cla bot added the cla: yes label Nov 2, 2020
@Snugug
Fix leading tags
93e8608 
Prettier was squishing them all to one line when they should be multiple
@Snugug
Don't escape underscores
f57d157
jeffposnick
jeffposnick approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Snugug!

@jeffposnick jeffposnick merged commit 4eb8127 into google:master Nov 2, 2020
This was referenced Nov 3, 2020
Closed
Closed
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffposnick jeffposnick jeffposnick approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Snugug @jeffposnick