Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bazel builds on macos_arm64 #1327

Merged
merged 6 commits into from
Mar 5, 2021

Conversation

simonmaurer
Copy link
Contributor

@simonmaurer simonmaurer commented Mar 3, 2021

with respect to this issue this PR allows bazel builds for the recent macos_arm64 platform.

verified using the following bazel versions:

  • bazel-3.7.2-darwin-x86_64
  • bazel-4.0.0-darwin-x86_64
  • bazel-4.0.0-homebrew
  • bazel-3.7.1-darwin-arm64

bazel -c opt --config=macos_arm64 :end2end_bench

specifying --config=macos_arm64 is mandatory to allow a succesful build of the XNNPACKlibrary
if we wanna build the ènd2end_bench another PR has to be made to track the latest commit of pthreadpool(once this PR is accepted)

as TensorFlow depends on XNNPACK, once this PR is accepted we can issue a PR on the official TensorFlow repo. this will allow bazel builds of the TensorFlow Lite library and the benchmark_model for platform macos_arm64

.bazelrc Outdated Show resolved Hide resolved
BUILD.bazel Outdated Show resolved Hide resolved
@simonmaurer
Copy link
Contributor Author

updated pthreadpool library, using latest commit which pulls in PR #14

end2end_bench can now be built using:

bazel -c opt --config=macos_arm64 :end2end_bench

@simonmaurer simonmaurer mentioned this pull request Mar 5, 2021
@simonmaurer
Copy link
Contributor Author

@Maratyszcza thank you for reviewing!

@copybara-service copybara-service bot merged commit 863d595 into google:master Mar 5, 2021
@simonmaurer simonmaurer deleted the macos_arm64_bazel_final branch March 6, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants