Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f32 Maxpool RVV implementation microkernels, tests and config changes. #6337

Merged
merged 8 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmake/gen/rvv_microkernels.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ SET(ALL_RVV_MICROKERNEL_SRCS
src/f32-igemm/gen/f32-igemm-7x4v-minmax-rvv.c
src/f32-igemm/gen/f32-igemm-7x4v-relu-rvv.c
src/f32-igemm/gen/f32-igemm-7x4v-rvv.c
src/f32-maxpool/gen/f32-maxpool-9p8x-minmax-rvv-c1v.c
src/f32-maxpool/gen/f32-maxpool-9p8x-minmax-rvv-c2v.c
src/f32-raddstoreexpminusmax/gen/f32-raddstoreexpminusmax-rvv-rr2-p6-u2v.c
src/f32-raddstoreexpminusmax/gen/f32-raddstoreexpminusmax-rvv-rr2-p6-u4v.c
src/f32-rminmax/gen/f32-rmax-rvv-u1v.c
Expand Down
2 changes: 2 additions & 0 deletions gen/rvv_microkernels.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ ALL_RVV_MICROKERNEL_SRCS = [
"src/f32-igemm/gen/f32-igemm-7x4v-minmax-rvv.c",
"src/f32-igemm/gen/f32-igemm-7x4v-relu-rvv.c",
"src/f32-igemm/gen/f32-igemm-7x4v-rvv.c",
"src/f32-maxpool/gen/f32-maxpool-9p8x-minmax-rvv-c1v.c",
"src/f32-maxpool/gen/f32-maxpool-9p8x-minmax-rvv-c2v.c",
"src/f32-raddstoreexpminusmax/gen/f32-raddstoreexpminusmax-rvv-rr2-p6-u2v.c",
"src/f32-raddstoreexpminusmax/gen/f32-raddstoreexpminusmax-rvv-rr2-p6-u4v.c",
"src/f32-rminmax/gen/f32-rmax-rvv-u1v.c",
Expand Down
11 changes: 11 additions & 0 deletions scripts/generate-f32-maxpool.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/bin/sh
# Copyright 2024 Imagination Technologies, inc.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.

################################ RISC-V Vector ################################
tools/xngen src/f32-maxpool/rvv.c.in -D LMUL=1 -o src/f32-maxpool/gen/f32-maxpool-9p8x-minmax-rvv-c1v.c &
tools/xngen src/f32-maxpool/rvv.c.in -D LMUL=2 -o src/f32-maxpool/gen/f32-maxpool-9p8x-minmax-rvv-c2v.c &

wait
168 changes: 168 additions & 0 deletions src/amalgam/gen/rvv.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <xnnpack/common.h>
#include <xnnpack/intrinsics-polyfill.h>
#include <xnnpack/math.h>
#include <xnnpack/maxpool.h>
#include <xnnpack/raddstoreexpminusmax.h>
#include <xnnpack/reduce.h>
#include <xnnpack/transpose.h>
Expand Down Expand Up @@ -224,6 +225,173 @@ void xnn_f32_avgpool_minmax_ukernel_9x__rvv_c2v(
} while (--output_pixels != 0);
}

void xnn_f32_maxpool_minmax_ukernel_9p8x__rvv_c2v(
size_t output_pixels,
size_t kernel_elements,
size_t channels,
const float** input,
size_t input_offset,
float* output,
size_t input_increment,
size_t output_increment,
const union xnn_f32_minmax_params params[restrict XNN_MIN_ELEMENTS(1)])
{
assert(output_pixels != 0);
assert(kernel_elements != 0);
assert(channels != 0);

const float output_min = params->scalar.min;
const float output_max = params->scalar.max;
do {
float* o = output;
{
const float* i0 = *input++;
const float* i1 = *input++;
const float* i2 = *input++;
const float* i3 = *input++;
const float* i4 = *input++;
const float* i5 = *input++;
const float* i6 = *input++;
const float* i7 = *input++;
const float* i8 = *input++;
i0 = (const float*) ((uintptr_t) i0 + input_offset);
i1 = (const float*) ((uintptr_t) i1 + input_offset);
i2 = (const float*) ((uintptr_t) i2 + input_offset);
i3 = (const float*) ((uintptr_t) i3 + input_offset);
i4 = (const float*) ((uintptr_t) i4 + input_offset);
i5 = (const float*) ((uintptr_t) i5 + input_offset);
i6 = (const float*) ((uintptr_t) i6 + input_offset);
i7 = (const float*) ((uintptr_t) i7 + input_offset);
i8 = (const float*) ((uintptr_t) i8 + input_offset);
if (kernel_elements < 2) {
i1 = i0;
}
if (kernel_elements <= 2) {
i2 = i0;
}
if (kernel_elements < 4) {
i3 = i0;
}
if (kernel_elements <= 4) {
i4 = i0;
}
if (kernel_elements < 6) {
i5 = i0;
}
if (kernel_elements <= 6) {
i6 = i0;
}
if (kernel_elements < 8) {
i7 = i0;
}
if (kernel_elements <= 8) {
i8 = i0;
}

size_t c = channels;
do {
int32_t n = __riscv_vsetvl_e32m2(c);

vfloat32m2_t i0_f32v = __riscv_vle32_v_f32m2(i0, n); i0 += n;
vfloat32m2_t i1_f32v = __riscv_vle32_v_f32m2(i1, n); i1 += n;
vfloat32m2_t i2_f32v = __riscv_vle32_v_f32m2(i2, n); i2 += n;
vfloat32m2_t i3_f32v = __riscv_vle32_v_f32m2(i3, n); i3 += n;
vfloat32m2_t i4_f32v = __riscv_vle32_v_f32m2(i4, n); i4 += n;
vfloat32m2_t i5_f32v = __riscv_vle32_v_f32m2(i5, n); i5 += n;
vfloat32m2_t i6_f32v = __riscv_vle32_v_f32m2(i6, n); i6 += n;
vfloat32m2_t i7_f32v = __riscv_vle32_v_f32m2(i7, n); i7 += n;
vfloat32m2_t i8_f32v = __riscv_vle32_v_f32m2(i8, n); i8 += n;

vfloat32m2_t max01_f32v = __riscv_vfmax_vv_f32m2(i0_f32v, i1_f32v, n);
vfloat32m2_t max23_f32v = __riscv_vfmax_vv_f32m2(i2_f32v, i3_f32v, n);
vfloat32m2_t max45_f32v = __riscv_vfmax_vv_f32m2(i4_f32v, i5_f32v, n);
vfloat32m2_t max67_f32v = __riscv_vfmax_vv_f32m2(i6_f32v, i7_f32v, n);
vfloat32m2_t max018_f32v = __riscv_vfmax_vv_f32m2(max01_f32v, i8_f32v, n);

vfloat32m2_t max2345_f32v = __riscv_vfmax_vv_f32m2(max23_f32v, max45_f32v, n);
vfloat32m2_t max01678_f32v = __riscv_vfmax_vv_f32m2(max67_f32v, max018_f32v, n);
vfloat32m2_t out_f32v = __riscv_vfmax_vv_f32m2(max2345_f32v, max01678_f32v, n);
out_f32v = __riscv_vfmin_vf_f32m2(__riscv_vfmax_vf_f32m2(out_f32v, output_min, n), output_max, n);
__riscv_vse32_v_f32m2(o, out_f32v, n); o += n;

c -= n;
} while (c != 0);
}

for (ptrdiff_t k = (ptrdiff_t) kernel_elements - 9; k > 0; k -= 8) {
const float* i0 = *input++;
const float* i1 = *input++;
const float* i2 = *input++;
const float* i3 = *input++;
const float* i4 = *input++;
const float* i5 = *input++;
const float* i6 = *input++;
const float* i7 = *input++;
i0 = (const float*) ((uintptr_t) i0 + input_offset);
i1 = (const float*) ((uintptr_t) i1 + input_offset);
i2 = (const float*) ((uintptr_t) i2 + input_offset);
i3 = (const float*) ((uintptr_t) i3 + input_offset);
i4 = (const float*) ((uintptr_t) i4 + input_offset);
i5 = (const float*) ((uintptr_t) i5 + input_offset);
i6 = (const float*) ((uintptr_t) i6 + input_offset);
i7 = (const float*) ((uintptr_t) i7 + input_offset);
if (k < 2) {
i1 = i0;
}
if (k <= 2) {
i2 = i0;
}
if (k < 4) {
i3 = i0;
}
if (k <= 4) {
i4 = i0;
}
if (k < 6) {
i5 = i0;
}
if (k <= 6) {
i6 = i0;
}
if (k < 8) {
i7 = i0;
}

o = output;
size_t c = channels;
do {
int32_t n = __riscv_vsetvl_e32m2(c);

vfloat32m2_t i0_f32v = __riscv_vle32_v_f32m2(i0, n); i0 += n;
vfloat32m2_t i1_f32v = __riscv_vle32_v_f32m2(i1, n); i1 += n;
vfloat32m2_t i2_f32v = __riscv_vle32_v_f32m2(i2, n); i2 += n;
vfloat32m2_t i3_f32v = __riscv_vle32_v_f32m2(i3, n); i3 += n;
vfloat32m2_t i4_f32v = __riscv_vle32_v_f32m2(i4, n); i4 += n;
vfloat32m2_t i5_f32v = __riscv_vle32_v_f32m2(i5, n); i5 += n;
vfloat32m2_t i6_f32v = __riscv_vle32_v_f32m2(i6, n); i6 += n;
vfloat32m2_t i7_f32v = __riscv_vle32_v_f32m2(i7, n); i7 += n;
vfloat32m2_t i8_f32v = __riscv_vle32_v_f32m2(o, n);

vfloat32m2_t max01_f32v = __riscv_vfmax_vv_f32m2(i0_f32v, i1_f32v, n);
vfloat32m2_t max23_f32v = __riscv_vfmax_vv_f32m2(i2_f32v, i3_f32v, n);
vfloat32m2_t max45_f32v = __riscv_vfmax_vv_f32m2(i4_f32v, i5_f32v, n);
vfloat32m2_t max67_f32v = __riscv_vfmax_vv_f32m2(i6_f32v, i7_f32v, n);
vfloat32m2_t max018_f32v = __riscv_vfmax_vv_f32m2(max01_f32v, i8_f32v, n);

vfloat32m2_t max2345_f32v = __riscv_vfmax_vv_f32m2(max23_f32v, max45_f32v, n);
vfloat32m2_t max01678_f32v = __riscv_vfmax_vv_f32m2(max67_f32v, max018_f32v, n);
vfloat32m2_t out_f32v = __riscv_vfmax_vv_f32m2(max2345_f32v, max01678_f32v, n);
out_f32v = __riscv_vfmin_vf_f32m2(__riscv_vfmax_vf_f32m2(out_f32v, output_min, n), output_max, n);
__riscv_vse32_v_f32m2(o, out_f32v, n); o += n;

c -= n;
} while (c != 0);
}
input = (const float**) ((uintptr_t) input + input_increment);
output = (float*) ((uintptr_t) o + output_increment);
} while (--output_pixels != 0);
}

static inline vfloat32m4_t eval_poly_horner(vfloat32m4_t x,
float c6, float c5,
float c4, float c3, float c2,
Expand Down
5 changes: 5 additions & 0 deletions src/configs/maxpool-config.c
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ static void init_f32_maxpool_config(void) {
f32_maxpool_config.init.f32 = xnn_init_f32_minmax_scalar_params;
f32_maxpool_config.first_pass_tile_size = 9;
f32_maxpool_config.remainder_pass_tile_size = 8;
#elif XNN_ARCH_RISCV && XNN_ENABLE_RISCV_VECTOR
f32_maxpool_config.ukernel = (xnn_maxpool_ukernel_fn) xnn_f32_maxpool_minmax_ukernel_9p8x__rvv_c2v;
f32_maxpool_config.init.f32 = xnn_init_f32_minmax_scalar_params;
f32_maxpool_config.first_pass_tile_size = 9;
f32_maxpool_config.remainder_pass_tile_size = 8;
#else
f32_maxpool_config.ukernel = (xnn_maxpool_ukernel_fn) xnn_f32_maxpool_minmax_ukernel_9p8x__scalar_c1;
f32_maxpool_config.init.f32 = xnn_init_f32_minmax_scalar_params;
Expand Down