Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Insets] Deprecate IME nested scroll connection #1141

Merged
merged 1 commit into from
May 12, 2022
Merged

[Insets] Deprecate IME nested scroll connection #1141

merged 1 commit into from
May 12, 2022

Conversation

alexvanyo
Copy link
Collaborator

The nested scroll connection is upstreamed, so we can now deprecated the accompanist version.

WIP until it is released in a non-snapshot version.

bentrengrove
bentrengrove approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@bentrengrove bentrengrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexvanyo
Copy link
Collaborator Author

Thanks @bentrengrove ! I am holding off on merging until the next release of compose, where imeNestedScroll() is first released (and make sure the links work!).

@alexvanyo alexvanyo marked this pull request as ready for review May 12, 2022 04:37
@alexvanyo alexvanyo merged commit dfa9b0d into main May 12, 2022
@alexvanyo alexvanyo deleted the av/deprecate-ime-nested-scroll-connectiong branch May 12, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentrengrove bentrengrove bentrengrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexvanyo @bentrengrove