Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwipeRefresh] Fix overscroll behaviour on Android 12 #1174

Merged
merged 1 commit into from Jun 8, 2022

Conversation

bentrengrove
Copy link
Collaborator

@bentrengrove bentrengrove commented May 25, 2022

Fixes #1059

Bug is easy to reproduce in the old implementation on Android 12. Start swipe refresh but then scroll the other direction to scroll the list down. The indicator will often get stuck.

This fixes it thanks to a suggestion in the issue by cancelling the in progress swipe if the conditions aren't met.

@bentrengrove bentrengrove requested a review from arriolac May 25, 2022
@bentrengrove bentrengrove merged commit 6a9615a into main Jun 8, 2022
11 checks passed
@bentrengrove bentrengrove deleted the ben/swiperefresh branch Jun 8, 2022
@demidenko
Copy link

demidenko commented Jun 26, 2022

Just tested new build with fix, issue is not fixed fully, sometimes circle still freezing allowing overscroll list animation :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Swipe to refresh] Indicator stuck on Android 12 stretch overscroll effect
3 participants