Keyboard (IME) animation support #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consp1racy
reviewed
Nov 13, 2020
insets/src/main/java/dev/chrisbanes/accompanist/insets/Insets.kt
Outdated
Show resolved
Hide resolved
|
Excited for this! |
Currently we create a new Modifier instance on each
inset value change since we compute a new insets inside of
composed { }, which isn't ideal. Instead, we have now moved
the computation within the layout block, which means only the
layout block will be restarted on composition changes.
Also added a enable/disable flag to ProvideWindowInsets
chrisbanes
force-pushed
the
cb/keyboard-animations
branch
from
3c03408
to
294a933
Compare
These are now behind an experimental flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings initial support for
WindowInsetsAnimationto Accompanist Insets. The API is marked as experimental, since it's not final and will likely be refined.WindowInsetsAnimationsupport