Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation] Bump Navigation version to 2.5.3 #1478

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

mkano9
Copy link
Contributor

@mkano9 mkano9 commented Jan 14, 2023

Updating the navigation library version to 2.5.3.

Release notes: https://developer.android.com/jetpack/androidx/releases/navigation#2.5.3

@google-cla
Copy link

google-cla bot commented Jan 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mkano9
Copy link
Contributor Author

mkano9 commented Jan 16, 2023

Looks like the test failure has nothing to do with navigation.

> Task :pager:connectedDebugAndroidTest FAILED

com.google.accompanist.pager.InstrumentedVerticalPagerTest > scrollToPage_withOffset_LaunchedEffect[contentPadding=PaddingValues(start=0.0.dp, top=0.0.dp, end=0.0.dp, bottom=0.0.dp),itemSpacing=4,reverseLayout=false][test(AVD) - 10] FAILED 
	java.lang.RuntimeException: android.os.DeadSystemException
	at android.view.autofill.AutofillManager.registerCallback(AutofillManager.java:1876)

@bentrengrove
Copy link
Collaborator

Yeah just a flake, I have hit retry

@bentrengrove bentrengrove merged commit afcba16 into google:main Jan 16, 2023
@mkano9
Copy link
Contributor Author

mkano9 commented Jan 16, 2023

Thank you! When can I expect this to make it to the snapshot?

@bentrengrove
Copy link
Collaborator

It should take about an hour or two. If you just add a dependency to your project for navigation 2.5.3, it will upgrade Accompanist via a transitive dependency anyway so you shouldn't need to wait for the snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants