[Image Loading] Skip initial Empty state
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now start from the Loading state, since we switch instantly to Loading in 99% of cases. This means we no longer display the Empty state as start before switching to Loading one composition later. We now treat Empty as a terminal/result state. Closes #141
chrisbanes
changed the title
Empty stateEmpty state
nickbutcher
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now start from the Loading state, since we switch instantly to Loading in 99% of cases. This means we no longer display the Empty state as start before switching to Loading one composition later.
We now treat Empty as a terminal/result state.
Closes #141