Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback navigation upgrade to latest stable #1554

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

bentrengrove
Copy link
Collaborator

Fixes #1552

@bentrengrove
Copy link
Collaborator Author

Looks like that gradle issue still exists. @jossiwolf, you need 2.6.0 for your work right?

@jossiwolf
Copy link
Collaborator

@bentrengrove I don't think we need any APIs or features specifically, but there have been quite a few important bugfixes. Tbh I think it's fine to depend on an alpha version in Accompanist, we do the same with other AndroidX dependencies. Do you think we should depend on a stable Nav version instead?

cc @jbw0033

@G00fY2
Copy link

G00fY2 commented Mar 24, 2023

@jossiwolf I heavily disagree on using transitive unstable dependencies in stable releases. Thats also not the case for any other Google library I am aware of.
The consumers should decide whether the bugfixes are important and justify using alpha releases.

We e.g. use this check (inspired by a discussion in the Gradle forum). The latest Accompanist release is the only dependency (also for the first time since we added this check a year ago) which causes a violation in our project with 150+ explicitly declared dependencies.

@JohannesPtaszyk
Copy link

Have to agree with @G00fY2. Transitive unstable dependencies in stable releases should be disallowed.

@bentrengrove
Copy link
Collaborator Author

We will be rolling back the navigation dependency to the last stable version and doing another Accompanist stable release.

@serhii-pokrovskyi
Copy link

We will be rolling back the navigation dependency to the last stable version and doing another Accompanist stable release.

any chances that this will fix?
I think that they are related
#1558

@bentrengrove bentrengrove mentioned this pull request Apr 3, 2023
@bentrengrove bentrengrove merged commit 6d93fb6 into main Apr 3, 2023
9 checks passed
@bentrengrove bentrengrove deleted the bugfix/ben/navigation branch April 3, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation Material] Current release 0.30.0 ships navigation-compose alpha
5 participants