-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollback navigation upgrade to latest stable #1554
Conversation
Looks like that gradle issue still exists. @jossiwolf, you need 2.6.0 for your work right? |
@bentrengrove I don't think we need any APIs or features specifically, but there have been quite a few important bugfixes. Tbh I think it's fine to depend on an alpha version in Accompanist, we do the same with other AndroidX dependencies. Do you think we should depend on a stable Nav version instead? cc @jbw0033 |
@jossiwolf I heavily disagree on using transitive unstable dependencies in stable releases. Thats also not the case for any other Google library I am aware of. We e.g. use this check (inspired by a discussion in the Gradle forum). The latest Accompanist release is the only dependency (also for the first time since we added this check a year ago) which causes a violation in our project with 150+ explicitly declared dependencies. |
Have to agree with @G00fY2. Transitive unstable dependencies in stable releases should be disallowed. |
We will be rolling back the navigation dependency to the last stable version and doing another Accompanist stable release. |
any chances that this will fix? |
cb47e71
to
ce8d614
Compare
Fixes #1552