Make coerceEachDimensionAtLeast() public API #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
force-pushed
the
cb/inset-api-public
branch
from
3160111
to
487f919
Compare
nickbutcher
approved these changes
Mar 15, 2021
| * dimension value in [minimumValue], otherwise a copy of this with each dimension coerced with the | ||
| * corresponding dimension value in [minimumValue]. | ||
| */ | ||
| fun Insets.coerceEachDimensionAtLeast(minimumValue: Insets): Insets { |
There was a problem hiding this comment.
coerce "each" or "all"?
There was a problem hiding this comment.
I was 50/50 on this tbh, but leaned towards 'each' to indicate that each dimension is coerced seperately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239