Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pager] Add VerticalPager #254

Merged
merged 8 commits into from
Mar 17, 2021
Merged

[Pager] Add VerticalPager #254

merged 8 commits into from
Mar 17, 2021

Conversation

chrisbanes
Copy link
Contributor

@chrisbanes chrisbanes commented Mar 17, 2021

Was surprisingly easy to refactor HorizontalPager. Most of the code changes is actually in the tests instead.

Demo

verticalpager.mp4

Closes #248

@google-cla google-cla bot added the cla: yes label Mar 17, 2021
Copy link

@matvei-g matvei-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

pager/src/main/java/com/google/accompanist/pager/Pager.kt Outdated Show resolved Hide resolved
pager/src/main/java/com/google/accompanist/pager/Pager.kt Outdated Show resolved Hide resolved
pager/src/main/java/com/google/accompanist/pager/Pager.kt Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Mar 17, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Mar 17, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 17, 2021
@chrisbanes
Copy link
Contributor Author

@googlebot I fixed it

@google google deleted a comment from google-cla bot Mar 17, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 17, 2021
@google google deleted a comment from google-cla bot Mar 17, 2021
@google google deleted a comment from google-cla bot Mar 17, 2021
@chrisbanes chrisbanes marked this pull request as ready for review March 17, 2021 13:25
Copy link

@matvei-g matvei-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris, one comment

@chrisbanes chrisbanes merged commit f79a85f into snapshot Mar 17, 2021
@chrisbanes chrisbanes deleted the cb/pager-vertical branch March 17, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants