[WindowInsets] Refactor inset values #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbanes
changed the title
chrisbanes
changed the title
nickbutcher
reviewed
May 5, 2021
insets/src/main/java/com/google/accompanist/insets/InsetValues.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
May 5, 2021
insets/src/main/java/com/google/accompanist/insets/InsetsType.kt
Outdated
Show resolved
Hide resolved
InsetValues -> Insets
nickbutcher
approved these changes
May 10, 2021
jossiwolf
pushed a commit
to jossiwolf/accompanist
that referenced
this pull request
Aug 1, 2021
* Add Insets Bottom Nav sample * Refactor systemBars to be a computed value instead * Tweak bottom nav sample visuas * Expand class structure * Fix API * Tidy up class structure and docs * Insets -> InsetValues The new name is clearer imo. * Remove bottom navigation sample * Add derivedInsetsTypeOf * Move InsetValues.coerceEachDimensionAtLeast * Fix tests * Remove JvmFile * InsetsType -> WindowInsets.Type InsetValues -> Insets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JvmFiles, there's no need to keep the API files 'clean'derivedWindowInsetsTypeOf()allowing creation of computed values (i.esystemBars)InsetsType->WindowInsets.Type