Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previewPlaceholder declaration in coil docs #410

Merged
merged 2 commits into from
May 17, 2021
Merged

Conversation

pawegio
Copy link
Contributor

@pawegio pawegio commented May 13, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label May 13, 2021
@pawegio
Copy link
Contributor Author

pawegio commented May 13, 2021

Initially I fixed the declaration in the docs causing compiler error, but I think it makes sense to remove previewPlaceholder from simplest usage as it has a default value and it's described later in Previews section.

@chrisbanes chrisbanes enabled auto-merge (squash) May 13, 2021 12:59
@chrisbanes chrisbanes disabled auto-merge May 17, 2021 10:27
@chrisbanes chrisbanes merged commit 1a18194 into google:main May 17, 2021
@chrisbanes chrisbanes added this to the v0.10.0 milestone May 18, 2021
jossiwolf pushed a commit to jossiwolf/accompanist that referenced this pull request Aug 1, 2021
* Fix previewPlaceholder declaration in coil docs

* Remove previewPlaceholder declaration from simplest usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants