-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More API changes #93
Merged
Merged
More API changes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nickbutcher
reviewed
Sep 22, 2020
coil/src/androidTest/java/dev/chrisbanes/accompanist/coil/CoilTest.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Sep 22, 2020
* This version of the function allows complete control over how the loaded image is displayed, | ||
* by being able to provide custom layout: | ||
* Creates a composable that will attempt to load the given [data] using [Coil], and provides | ||
* complete content of how the current state is displayed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/content/control?
nickbutcher
reviewed
Sep 22, 2020
nickbutcher
reviewed
Sep 22, 2020
nickbutcher
reviewed
Sep 22, 2020
nickbutcher
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small doc suggestions but changes LG. I like the easy default but ability to customize everything if you want.
- New tests for content composable - We now use MockWebServer to fetch images over the 'network'.
chrisbanes
force-pushed
the
cb/more-api-changes
branch
from
September 22, 2020 17:41
d7ef436
to
de068e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're on a roll of API changes, here's one final change:
SuccessResult
andErrorResult
have now been expanded in the sealedCoilImageState
, which now contains:Success
,Error
,Loading
&Empty
CoilImage
with theimage
composable has been expanded and made more flexible:The more opinionated (and easier to use) version which hosts content slots still exists, allowing:
Closes #92