-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement -check
flag and exit codes
#29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let's revert changes to travis CI config, go.mod and go.sum. They are good changes but they are out of scope here and should be sent in a separate PR.
It just makes it so much easier to review a change when it isn't cluttered with unrelated modifications.
@x1ddos I'll review the recommended changes. However, the implementation requires the ability to handle errors in |
The program now exits with a non-zero code when errors are encountered while reading and/or writing files. This now also introduces Go Modules for dependency management
@x1ddos I've updated the PR with recommended changes. Note that changes to travis CI config, go.mod, and go.sum are part of this PR since they are required for PR tests to pass. |
Sorry, got distracted by other things. Let me take a look. |
When this flag is used: * The program never modifies any files * If all files in the pattern contain a license, the program exits with a zero exit code * If at least one file in the pattern requires modification to include license text, the program prints such files to STDOUT and exits with a non-zero exit code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #28