Skip to content

Commit

Permalink
Use grpc's forceful stop instead of the graceful stop.
Browse files Browse the repository at this point in the history
The graceful stop seems to deadlock when there are streaming RPCs.
  • Loading branch information
pmuetschard committed Sep 11, 2020
1 parent 0553055 commit 4ddd08c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gapis/server/grpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ func (s *grpcServer) stopIfIdle(ctx context.Context, server *grpc.Server, idleTi
stoppedSignal, stopped := task.NewSignal()
defer func() {
stop()
server.GracefulStop()
server.Stop()
stopped(ctx)
}()

Expand Down Expand Up @@ -171,7 +171,7 @@ func (s *grpcServer) stopOnInterrupt(ctx context.Context, server *grpc.Server, s
stoppedSignal, stopped := task.NewSignal()
defer func() {
stop()
server.GracefulStop()
server.Stop()
stopped(ctx)
}()

Expand Down

0 comments on commit 4ddd08c

Please sign in to comment.