Merge the latest GAPID changes to AGI #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add systematic error reporting to Transforms. In practice, this means adding error reporting the following: gapis/api/transform.Transforms.Tranform() gapis/api/transform.Writer:MutateAndWrite() gapis/api/transform.Writer:Flush() gapis/api/transform.Writer:Transform() Some experimental measurement show no perceivable performance impact on the execution of transforms. Bug: b/145003736
Keep track of every hover-related value in a single place.
If the tooltip is smaller than the sample, show it after the sample. This way it won't overlap the sample and hide it.
The gpu.renderstages producer can be implemented in prerelease driver UMD or the VkRenderStagesProducer layer. To properly detect render stage capacbility, we need to properly set up the environement for device info service. Bug: b/142480442
Output a single JSON list containing all info for all devices. Remove any other output not going through core.log functionnality. This enables to get a clean JSON output when suppressing gapid logging, e.g.: ``` gapit -log-level Fatal devices ``` Bug: b/147805965 Fixes #3659
Fixes b/148513938
Let's not pollute the user's app launcher. Our users don't really have a need to launch the spinning cube from the app launcher.
As soon as draw-calls are grouped, now they will be able to be generated efficiently. This is the second in a series of cleanups to simplify mutate and command-tracking.
This change adds partial support for timeline semaphores.
…ane (#3697) Update Perfetto & UI to show vulkan debug markers in selection view The debug markers are now direct fields in the gpu_slice table and this requires some UI changes to be shown properly. Bug: 140590067
The logic to decide how to load the Vulkan interception layer was based on GLES layer support. This change separates the two APIs, such that the system settings are use to load the Vulkan interception layer as soon as the Android version allows it, regardless of GLES layer support. Bug: b/147723153#comment61
BUG: b/148600467
- better distinction for vsync vs titles - better dark theme
We will use the default color, even on slice backgrounds.
- Adds a few more colors. - Makes them work better with text/borders - Some clean-ups in how highlights are rendered.
track_event.timestamp_absolute_us is set using BOOTTIME clock, but assumed to be MONOTONIC in the trace processor. The field is no longer necessary as it is obsoleted by clock domain in Perfetto. Bug: b/148481683
Nil resources are not actually resources.
If there is only one queue, just show the track by itself.
If there is only one buffer, just show the track by itself.
If there is only one counter, just show the track by itself.
Also, if the text is too long, before truncating, show it without the PID/TID.
There is still some type information that is lost, but it requires a refactor to fix.
Perfetto daemons are not required to run on the device, and the daemons must be running in order to allow the data producers register themselves, hence before we do any interaction between the tool and Perfetto, we must make sure Perfetto daemons are running and persistent. Note that there's a delay between setting the system property and the daemons finish starting, hence we need to set the system property as early as possible. Also update the test faked device to Android 10. Bug: b/148566762
Removing an unneeded std::mutex for every call to spy::get() Replace a bunch of new/delete pairs with stack-scoped objects. BUG: No Bug
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
stellama0208
added a commit
that referenced
this pull request
Mar 12, 2020
stellama0208
added a commit
to stellama0208/agi
that referenced
this pull request
May 6, 2020
stellama0208
added a commit
to stellama0208/agi
that referenced
this pull request
May 27, 2020
stellama0208
added a commit
to stellama0208/agi
that referenced
this pull request
Jul 21, 2020
stellama0208
added a commit
to stellama0208/agi
that referenced
this pull request
Jul 23, 2020
stellama0208
added a commit
to stellama0208/agi
that referenced
this pull request
Sep 24, 2020
stellama0208
added a commit
to stellama0208/agi
that referenced
this pull request
Sep 24, 2020
stellama0208
added a commit
to stellama0208/agi
that referenced
this pull request
Sep 24, 2020
stellama0208
added a commit
to stellama0208/agi
that referenced
this pull request
Dec 8, 2020
stellama0208
added a commit
to stellama0208/agi
that referenced
this pull request
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.