-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API to support saving local only resources #2123
Comments
Appears in Kotlin an overriding function is not allowed to specify default values for its parameters. I will therefore make a PR with the original solution and we can iterate on that if need be. |
what does it mean for a non-local only resource to depend on a local only resource? this shouldn't really work as we'd be potentially breaking data integrity on the server if the non-local only resource is uploaded to the server. to what extent is this a problem in our case and how should we handle it? |
ping @ndegwamartin |
Is your feature request related to a problem? Please describe.
Sometimes we need to persist resources on the device's database without creating local changes to be synced to the server. Such resources may be downloaded from the server or perhaps generated by the client itself.
Currently the only way to persist a resource is to use the
FhirEngine.create
API method which flags the resources for sync.Describe the solution you'd like
This could be solved by exposing the
Database.insertRemote
API via theFhirEngine
API by adding the following interface and implementation.Describe alternatives you've considered
An alternative approach could be to enhance the current
FhirEngine.create
API and pass a flag to determine whether it should be marked for sync or is a local only resource.Might be better to name the flag something like
isSyncable
orsyncUp
and set its default totrue
to avoid any confusion with the existing concept of local changes.Additional context
N/A
Would you like to work on the issue?
Yes
The text was updated successfully, but these errors were encountered: