Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo app reskinning. #2188

Closed
santosh-pingle opened this issue Sep 20, 2023 · 10 comments · Fixed by #2414
Closed

Demo app reskinning. #2188

santosh-pingle opened this issue Sep 20, 2023 · 10 comments · Fixed by #2414
Assignees
Labels
type:enhancement New feature or request ux

Comments

@santosh-pingle
Copy link
Collaborator

Describe the bug
Update visual appearance of demo app.
Refer below link for reference
https://github.com/google/fhir-app-examples/tree/main/configurablecare

Component
reference app

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. Pixel4a emulator]
  • Android version: [e.g. Settings -> About phone -> Android version]
  • Build number: [e.g. Settings -> About phone -> Build number]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@santosh-pingle santosh-pingle added the type:enhancement New feature or request label Sep 20, 2023
@santosh-pingle santosh-pingle self-assigned this Sep 20, 2023
@santosh-pingle
Copy link
Collaborator Author

Registered Patients Screen

  1. Change the app bar background to match the rest of the screen (white).
  2. Remove the margin at the start and end of the divider.
  3. Align the patient contents to the left and reduce the margin at the start.
  4. Reduce the margin at the start for the number of patients and align this text with the patient list.
Screenshot 2023-09-25 at 10 03 46 AM

@santosh-pingle
Copy link
Collaborator Author

Patient Card Screen :

  1. Round the corners of the complete survey button.
  2. Remove the left margin of the card.
  3. Update the background of the patient card.
  4. Remove the right margin of the card.
  5. Adjust the app bar background to match the screen's background (white).
Screenshot 2023-09-25 at 10 25 02 AM

@santosh-pingle
Copy link
Collaborator Author

Edit Patient :

  1. Adjust the app bar background to match the screen's background (white).
Screenshot 2023-09-25 at 12 00 42 PM

@santosh-pingle
Copy link
Collaborator Author

Add Patient :

  1. Adjust the app bar background to match the screen's background (white).
Screenshot 2023-09-25 at 12 06 55 PM

@santosh-pingle
Copy link
Collaborator Author

Action item :
Migrate from material 2 to material 3.

I will start with this.

@MJ1998
Copy link
Collaborator

MJ1998 commented Sep 29, 2023

Do you think we should also add a menu / home page something like this (but without the Implementation Guide box)?
Screenshot 2023-09-29 at 2 14 11 PM

@MJ1998
Copy link
Collaborator

MJ1998 commented Sep 29, 2023

Regarding the 3rd issue on Registered Patients Screen, the left blank portion we see is for the patient status based on the risk probability. Currently no RiskAssessment resources are synced hence no statusView is assigned and the view is blank. Do we wanna remove the risk-to-status binding and relevant codes as well ?
Code Link

@santosh-pingle
Copy link
Collaborator Author

Do you think we should also add a menu / home page something like this (but without the Implementation Guide box)? Screenshot 2023-09-29 at 2 14 11 PM

thanks @MJ1998

I think it might be a good idea to add a dashboard. What are your thoughts?@shelaghm @jingtang10

@santosh-pingle
Copy link
Collaborator Author

Regarding the 3rd issue on Registered Patients Screen, the left blank portion we see is for the patient status based on the risk probability. Currently no RiskAssessment resources are synced hence no statusView is assigned and the view is blank. Do we wanna remove the risk-to-status binding and relevant codes as well ? Code Link

yes.
It might be a good idea to align the risk assessment status in such a way that it doesn't appear as a blank space. What are your thoughts on this? @shelaghm @jingtang10

@MJ1998 MJ1998 mentioned this issue Oct 9, 2023
7 tasks
@jingtang10
Copy link
Collaborator

can you take a look at this @santosh-pingle https://github.com/google/fhir-app-examples/tree/main/configurablecare and try to match the style there in the demo app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request ux
Projects
Status: Complete
3 participants