Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All contributors have to be able to see functional test logs for PRs on the Firebase UI #2218

Open
vorburger opened this issue Sep 29, 2023 · 3 comments
Assignees
Labels
effort:medium Medium effort - 3 to 5 days P1 High priority issue type:bug Something isn't working type:build Issues related to code build type:testing Improvements on tests or testing infrastructure

Comments

@vorburger
Copy link
Member

vorburger commented Sep 29, 2023

As-is right now, only "Googlers" can see the results (logs, and UI; example) of the many great functional UI tests which this project already has in its codebase in this Git repo and which Google runs "internally" for this project, using https://firebase.google.com/docs/test-lab.

This is not "open source community friendly" from a "theoretical" point of view; but more practically, this is a hindrance to better engage community contributions - it's hard(er) [than it should be] for contributors to work on Pull Requests for bug fixes and new features if they cannot see why their UI tests fail.

How we can solve this isn't entirely clear yet. I volunteer to investigate this a bit more, and document what I learn about this here.

@jingtang10 @omarismail94 this is to track what we chat today; /Cc @fredhersch FYI.

@vorburger vorburger added type:bug Something isn't working type:testing Improvements on tests or testing infrastructure P1 High priority issue effort:medium Medium effort - 3 to 5 days type:build Issues related to code build labels Sep 29, 2023
@vorburger vorburger self-assigned this Sep 29, 2023
@vorburger
Copy link
Member Author

OK so I tried adding the allUsers GCP Principal (or allAuthenticatedUsers) where needed, but:

Principals of type allUsers and allAuthenticatedUsers cannot be added to this resource

@jingtang10 @omarismail94 I'll keep digging...

@vorburger
Copy link
Member Author

To be sure that this is not a "Google internal restriction", I have also created a Firebase Test Lab project on my personal private home consumer GCP account, but it has shows the same message, so this isn't just an "Org Policy" type restriction, but appears to be a restriction built-into Firebase Test Lab?

@vorburger
Copy link
Member Author

I have internally reached out to some people to see if it's possible to find a solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:medium Medium effort - 3 to 5 days P1 High priority issue type:bug Something isn't working type:build Issues related to code build type:testing Improvements on tests or testing infrastructure
Projects
Status: New
Development

No branches or pull requests

1 participant