Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate synchronization APIs from data access APIs #428

Closed
jingtang10 opened this issue Apr 5, 2021 · 2 comments
Closed

Seperate synchronization APIs from data access APIs #428

jingtang10 opened this issue Apr 5, 2021 · 2 comments
Assignees
Labels
P1 High priority issue type:enhancement New feature or request

Comments

@jingtang10
Copy link
Collaborator

Describe the issue to be researched
The APIs for local resources and sync are quite tightly coupled at the moment. The FhirEngine interface definitely doesn't follow the single-responsibility principle.

Describe the goal of the research
Find out if there's a way to decouple the core storage APIs and sync APIs.

Describe the methodology
Prototyping. Researching other similar codebases.

Would you like to work on the issue?
Yes :)

@jingtang10 jingtang10 added the type:research Research or prototype something new label Apr 5, 2021
@jingtang10 jingtang10 self-assigned this Apr 5, 2021
@jingtang10 jingtang10 added this to To do in FHIR engine library via automation Apr 5, 2021
@jingtang10 jingtang10 added type:enhancement New feature or request and removed type:research Research or prototype something new labels May 6, 2021
@jingtang10 jingtang10 changed the title Explore creating a separate module for synchronization Seperate synchronization APIs from data access APIs May 6, 2021
@jingtang10
Copy link
Collaborator Author

I will continue to work on the draft PR but instead of creating a separate module to host the synchronization APIs, we will keep them in FHIR engine but make sure they are decoupled from the database access APIs.

@fredhersch fredhersch added the P1 High priority issue label May 6, 2021
@jingtang10
Copy link
Collaborator Author

This is done.

FHIR engine library automation moved this from To do to Done Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue type:enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants