Prototype to create a separate sync module #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
requested review from
kevinmost,
florina-muntenescu,
yigit and
deepankarb
yigit
reviewed
Apr 7, 2021
deepankarb
reviewed
Apr 13, 2021
| import org.hl7.fhir.r4.model.ResourceType | ||
|
|
||
| @Dao | ||
| interface SyncedResourceDao { | ||
|
|
||
| @Insert(onConflict = OnConflictStrategy.REPLACE) suspend fun insert(entity: SyncedResourceEntity) | ||
|
|
||
| @Transaction | ||
| suspend fun insertAll(resources: List<SyncedResourceEntity>) { |
There was a problem hiding this comment.
Use kotlin var args for API consistency?
sync/src/androidTest/java/com/google/android/fhir/sync/ExampleInstrumentedTest.kt
Show resolved
Hide resolved
| * `SyncData(ResourceType.Patient, mapOf("address-country" to "United States")` | ||
| */ | ||
| typealias ParamMap = Map<String, String> | ||
| typealias SyncData = Map<ResourceType, ParamMap> |
There was a problem hiding this comment.
Can we improve on the naming SyncData. Off the cuff it sounds like data that needs be synced whereas this is more like Sync parameters by resource. Maybe ResourceSyncParams?
|
closing this as this is being reworked in #482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #428
Description
Separate the sync code into a new module. This is done via creating clear separation of concerns in the
FhirEngineAPI.Alternative(s) considered
This is an improvement on the existing approach.
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project./gradlew checkand./gradlew connectedCheckto test my changes locally