Cleanup and moved Date and Time pickers to material #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-07
requested review from
jingtang10,
kevinmost,
ktarasenko,
stevenckngaa,
vvikramraj and
yigit
as code owners
aditya-07
added
type:code health
Data capture
and removed
type:bug
Codecov Report
@@ Coverage Diff @@
## master #1312 +/- ##
============================================
+ Coverage 83.72% 83.96% +0.24%
+ Complexity 690 687 -3
============================================
Files 148 148
Lines 10708 10694 -14
Branches 836 846 +10
============================================
+ Hits 8965 8979 +14
+ Misses 1340 1310 -30
- Partials 403 405 +2
Continue to review full report at Codecov.
|
|
@santosh-pingle can you please leave a review |
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Apr 25, 2022
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Apr 28, 2022
Comment on lines
+29
to
+30
| val date = Date.from(atZone(ZoneId.systemDefault()).toInstant()) | ||
| return DateFormat.getTimeFormat(context).format(date) |
There was a problem hiding this comment.
this should just call the function in MoreLocalTimes.kt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
QuestionnaireItemDatePickerViewHolderFactory.QuestionnaireItemDateTimePickerViewHolderFactoryand cleaned up code as well.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Code health
Screenshots (if applicable)
Date-Time-Picker-Material.mov
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.