Remove extra space from a Questionnaire View when the group headers have no text to show. #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-07
requested review from
jingtang10,
kevinmost,
ktarasenko,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1339 +/- ##
=========================================
Coverage 84.57% 84.57%
- Complexity 687 690 +3
=========================================
Files 148 148
Lines 10701 10708 +7
Branches 832 836 +4
=========================================
+ Hits 9050 9056 +6
Misses 1237 1237
- Partials 414 415 +1
Continue to review full report at Codecov.
|
jingtang10
approved these changes
Apr 28, 2022
...in/java/com/google/android/fhir/datacapture/views/QuestionnaireItemGroupViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...pture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderView.kt
Outdated
Show resolved
Hide resolved
...ava/com/google/android/fhir/datacapture/views/QuestionnaireItemGroupViewHolderFactoryTest.kt
Outdated
Show resolved
Hide resolved
...e/src/test/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderViewTest.kt
Show resolved
Hide resolved
jingtang10
reviewed
Apr 28, 2022
datacapture/src/main/res/layout/questionnaire_item_group_header_view.xml
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Apr 28, 2022
| @@ -43,6 +43,8 @@ internal object QuestionnaireItemGroupViewHolderFactory : | |||
| error.text = | |||
| if (validationResult.getSingleStringValidationMessage() == "") null | |||
| else validationResult.getSingleStringValidationMessage() | |||
|
|
|||
| error.visibility = if (error.text.isNotEmpty()) View.VISIBLE else View.GONE | |||
There was a problem hiding this comment.
Can you use isNullOrEmpty?
There was a problem hiding this comment.
discussed with @aditya-07 offline - text view always returns non-null string, so this should be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
QuestionnaireItemHeaderViewi.e. No prefix, question or hint, then set the visibility of the View as GONE. Otherwise there will be blank space.Based on Jing's comment below, error can be shown in the
QuestionnaireItemGroupViewHolder. So, keepingErrorView.Alternative(s) considered
The alternative would be to weed out such
QuestionnaireItemComponentwhile processingQuestionnaireso that they are not in the list provided to theRecyclerView.Type
Choose one: Bug fix
Screenshots (if applicable)
Black lines here are the
DividerItemDecorationto display the rows in the recyclerview.Before:
After:
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.