Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extraction for choice type values #1352

Merged
merged 5 commits into from
May 5, 2022

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Apr 30, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Contributor

@kevinmost kevinmost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 nit

@jingtang10 jingtang10 enabled auto-merge (squash) May 5, 2022 12:19
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1352 (214fad5) into master (8d5bc32) will increase coverage by 0.03%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master    #1352      +/-   ##
============================================
+ Coverage     84.60%   84.64%   +0.03%     
- Complexity      699      701       +2     
============================================
  Files           148      148              
  Lines         10719    10726       +7     
  Branches        853      854       +1     
============================================
+ Hits           9069     9079      +10     
- Misses         1228     1229       +1     
+ Partials        422      418       -4     
Impacted Files Coverage Δ
...android/fhir/datacapture/mapping/ResourceMapper.kt 85.50% <72.72%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5bc32...214fad5. Read the comment docs.

@jingtang10 jingtang10 merged commit ffcad63 into google:master May 5, 2022
@jingtang10 jingtang10 deleted the jt/extraction-string branch May 5, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants