Initial version of the SDC lib codelab #1429
Conversation
jingtang10
requested review from
aditya-07,
kevinmost,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
| @@ -0,0 +1,48 @@ | |||
| plugins { | |||
There was a problem hiding this comment.
Is there a reason the file format is not .kts like the rest of the files?
| val appContext = InstrumentationRegistry.getInstrumentation().targetContext | ||
| assertEquals("com.example.foodallergy", appContext.packageName) | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: add empty new line below
There was a problem hiding this comment.
deleted this file.
codelabs/datacapture/app/src/main/java/com/example/foodallergy/MainActivity.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1429 +/- ##
=========================================
Coverage 85.68% 85.68%
Complexity 716 716
=========================================
Files 149 149
Lines 10765 10765
Branches 858 858
=========================================
Hits 9224 9224
Misses 1100 1100
Partials 441 441 Continue to review full report at Codecov.
|
| val appContext = InstrumentationRegistry.getInstrumentation().targetContext | ||
| assertEquals("com.example.foodallergy", appContext.packageName) | ||
| } | ||
| } |
There was a problem hiding this comment.
deleted this file.
codelabs/datacapture/app/src/main/java/com/example/foodallergy/MainActivity.kt
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,48 @@ | |||
| plugins { | |||
| } | ||
| } | ||
| compileOptions { | ||
| sourceCompatibility = JavaVersion.VERSION_1_8 |
There was a problem hiding this comment.
Is there any reason we dont use Java 11 as the base? I am assume it has to do with old Android versions - is that the case?
There was a problem hiding this comment.
We have been using java8 for the main project. There just isn't a need to upgrade to java11 yet. I think java8 support was only introduced in Android studio recently. See "Use Java 8 language features and APIs | Android Developers" https://developer.android.com/studio/write/java8-support
I suggest we address this issue separately.
codelabs/datacapture/app/src/main/java/com/example/foodallergy/MainActivity.kt
Show resolved
Hide resolved
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
This is initially developed as part of the digital square webinar: https://github.com/openhie/FoodAllergy-webinar/tree/master/android
Alternative(s) considered
NA
Type
Documentation
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.