Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for the data capture codelab #1436

Merged
merged 23 commits into from
Jun 6, 2022

Conversation

jingtang10
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Update README.md for the data capture codelab

Alternative(s) considered
NA

Type
Documentation

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10
Copy link
Collaborator Author

@williamito @omarismail94

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads really well!

codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #1436 (846fba3) into master (6782042) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1436   +/-   ##
=========================================
  Coverage     85.68%   85.68%           
  Complexity      716      716           
=========================================
  Files           149      149           
  Lines         10768    10768           
  Branches        860      860           
=========================================
  Hits           9227     9227           
  Misses         1100     1100           
  Partials        441      441           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dfdfb5...846fba3. Read the comment docs.

codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
jingtang10 and others added 12 commits June 6, 2022 00:29
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
Co-authored-by: williamito <william.ito@gmail.com>
@jingtang10
Copy link
Collaborator Author

Thanks both @omarismail94 and @williamito - ptal!

@jingtang10 jingtang10 enabled auto-merge (squash) June 6, 2022 00:43
@williamito
Copy link
Contributor

LGTM.
Apologies for the CLA error, I had the wrong default email address set for web-based edits and I don't think there's a way for me to fix it after the fact. You will probably need to request an override, or let me know how I can help.

@jingtang10
Copy link
Collaborator Author

@williamito this should be fixable - can you try following the details of the failed check, it'll lead you to a page with a link to sign the cla using your personal email. thanks!

1 similar comment
@jingtang10
Copy link
Collaborator Author

@williamito this should be fixable - can you try following the details of the failed check, it'll lead you to a page with a link to sign the cla using your personal email. thanks!

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @jingtang10 ! Had more time today to look in more detail and left a few more comments :)

codelabs/datacapture/README.md Show resolved Hide resolved
codelabs/datacapture/README.md Show resolved Hide resolved
codelabs/datacapture/README.md Show resolved Hide resolved
codelabs/datacapture/README.md Show resolved Hide resolved
codelabs/datacapture/README.md Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Outdated Show resolved Hide resolved
codelabs/datacapture/README.md Show resolved Hide resolved
codelabs/datacapture/README.md Show resolved Hide resolved
codelabs/datacapture/README.md Show resolved Hide resolved
@jingtang10
Copy link
Collaborator Author

@omarismail94 by the way this is all @williamito 's work. he did all the writing. all credits to him.

@jingtang10 jingtang10 merged commit 2c069e5 into google:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants