Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Structured Data Capture Library codelab #1448

Merged
merged 8 commits into from
Jun 7, 2022

Conversation

jingtang10
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description

  • Remove some commented out code for user to copy+paste from codelab directly
  • Use coroutine for extraction
  • Fix issue where there isn't a questionnaire json string variable in the activity
  • Add menu

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Documentation

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10
Copy link
Collaborator Author

thanks omar - comments addressed.

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! 🎉

@jingtang10 jingtang10 enabled auto-merge (squash) June 7, 2022 18:08
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1448 (d563167) into master (e17ee6e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1448   +/-   ##
=========================================
  Coverage     85.68%   85.68%           
  Complexity      716      716           
=========================================
  Files           149      149           
  Lines         10768    10768           
  Branches        860      860           
=========================================
  Hits           9227     9227           
  Misses         1100     1100           
  Partials        441      441           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17ee6e...d563167. Read the comment docs.

@jingtang10 jingtang10 merged commit 1394135 into google:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants