Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects misleading error message in QuestionnaireViewModel #1461

Merged
merged 10 commits into from Jul 4, 2022

Conversation

vishnuravi
Copy link
Contributor

@vishnuravi vishnuravi commented Jun 20, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

An issue was not created as this is a straightforward change.

Description
Fixes error messages within QuestionnaireViewModel that reference incorrect property names.

Alternative(s) considered
No alternatives available.

Type
Bug fix

Screenshots (if applicable)
N/A

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

FYI @stevenckngaa

@jingtang10 jingtang10 enabled auto-merge (squash) June 20, 2022 20:24
auto-merge was automatically disabled June 20, 2022 21:42

Head branch was pushed to by a user without write access

@jingtang10 jingtang10 enabled auto-merge (squash) June 21, 2022 10:20
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #1461 (23736d9) into master (63fc76f) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master    #1461   +/-   ##
=========================================
  Coverage     90.07%   90.07%           
  Complexity      648      648           
=========================================
  Files           129      129           
  Lines          9843     9844    +1     
  Branches        716      716           
=========================================
+ Hits           8866     8867    +1     
  Misses          591      591           
  Partials        386      386           
Impacted Files Coverage Δ
...android/fhir/datacapture/QuestionnaireViewModel.kt 78.30% <66.66%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c047cc3...23736d9. Read the comment docs.

@jingtang10 jingtang10 merged commit 3068009 into google:master Jul 4, 2022
@Tarun-Bhardwaj Tarun-Bhardwaj added type:bug Something isn't working Data capture labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants