Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests to sync classes #1505

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Conversation

roywanyaga
Copy link
Collaborator

@roywanyaga roywanyaga commented Jul 26, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Add tests to engine module sync classes:

  • sync/download/ResourceParamsBasedDownloadWorkManager
  • sync/upload/BundleUploader
  • sync/upload/TransactionBundleGenerator

Alternative(s) considered
N/A

Type
Testing

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

sync/download/ResourceParamsBasedDownloadWorkManagerTest.kt, sync/upload/BundleUploaderTest.kt, /sync/upload/TransactionBundleGeneratorTest.kt
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1505 (d39d9df) into master (87c3437) will increase coverage by 74.84%.
The diff coverage is n/a.

❗ Current head d39d9df differs from pull request most recent head 9c2cef6. Consider uploading reports for the commit 9c2cef6 to get more accurate results

@@              Coverage Diff              @@
##             master    #1505       +/-   ##
=============================================
+ Coverage          0   74.84%   +74.84%     
- Complexity        0      663      +663     
=============================================
  Files             0      128      +128     
  Lines             0     3995     +3995     
  Branches          0      726      +726     
=============================================
+ Hits              0     2990     +2990     
- Misses            0      611      +611     
- Partials          0      394      +394     

see 128 files with indirect coverage changes

@jingtang10 jingtang10 enabled auto-merge (squash) December 4, 2022 23:25
@omarismail94
Copy link
Contributor

@roywanyaga can you update this PR to merge the changes in master, resolving any conflict? It should get merged once it passes the tests we have

@jingtang10
Copy link
Collaborator

I tidied this PR up - @omarismail94 can you take a look please? Thanks!

@jingtang10 jingtang10 merged commit 8c97ba6 into google:master Sep 13, 2023
2 of 3 checks passed
@jingtang10 jingtang10 deleted the add-sync-test-cases branch September 13, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

4 participants