Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify data endpoint when invoking $apply on a PlanDefinition #1982

Merged
merged 3 commits into from Apr 25, 2023

Conversation

divyaramnath-13
Copy link
Contributor

@divyaramnath-13 divyaramnath-13 commented Apr 21, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1981

Description
The data endpoint needs to be specified when invoking $apply on a PlanDefinition that contains an applicability condition represented as a CQL expression defined in a Library resource. If this is not set, the CQL logic will not be evaluated and the corresponding PlanDefinition action will not be executed.

Type
Choose one: Bug fix

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@divyaramnath-13 divyaramnath-13 changed the title Specify data endpoint when invoking on a PlanDefinition Specify data endpoint when invoking $apply on a PlanDefinition Apr 21, 2023
@divyaramnath-13
Copy link
Contributor Author

Looping in @vitorpamplona

@vitorpamplona
Copy link
Collaborator

vitorpamplona commented Apr 21, 2023

LGTM We might need to do the same work for the terminology and content endpoints, but maybe we should wait to see an issue first.

@aditya-07 aditya-07 merged commit 244fedc into google:master Apr 25, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
4 participants