Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the width to match the parent. #2105

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2057

Description
Update the imageview width to match the parent.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator Author

santosh-pingle commented Aug 1, 2023

Before Fix

Screen.Recording.2023-08-01.at.12.12.54.PM.mov

@FikriMilano
After fix :

Screen.Recording.2023-08-01.at.12.04.23.PM.mov

@santosh-pingle santosh-pingle marked this pull request as ready for review August 1, 2023 07:15
@santosh-pingle santosh-pingle requested a review from a team as a code owner August 1, 2023 07:15
Copy link
Collaborator

@FikriMilano FikriMilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santosh-pingle looks good to me, thanks :D

@jingtang10 jingtang10 enabled auto-merge (squash) August 10, 2023 13:53
@jingtang10 jingtang10 merged commit de46260 into google:master Aug 11, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Image shows different size bug
3 participants