Clean up SyncJobStatus and add FhirSynchronizer test #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarismail94
requested review from
santosh-pingle and
a team
as code owners
anchita-g
reviewed
Sep 20, 2023
demo/src/main/java/com/google/android/fhir/demo/MainActivityViewModel.kt
Outdated
Show resolved
Hide resolved
aditya-07
reviewed
Sep 26, 2023
engine/src/test/java/com/google/android/fhir/sync/FhirSynchronizerTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Sep 26, 2023
anchita-g
pushed a commit
to anchita-g/android-fhir
that referenced
this pull request
Sep 29, 2023
* Clean up SyncJobStatus and add FhirSynchronizer test * remove changes in MAVM * refactor more
omarismail94
added a commit
that referenced
this pull request
Oct 26, 2023
* WIP * test cases * Adding resource UUID in LocalChangeEntity * fixing migration tests * returning resource UUID for insert resource * Clean up SyncJobStatus and add FhirSynchronizer test (#2184) * Clean up SyncJobStatus and add FhirSynchronizer test * remove changes in MAVM * refactor more * Consolidator done * review comments * adding more tests * fix failing test cases * Introducing LocalChangeReference * Adding LocalChangeDaoTest * WIP * added migration and tests for migration * updating kdoc * adding database migration * removing unused refs * json utils test * review comments * addressing review comments * resolving failing test case --------- Co-authored-by: Omar Ismail <44980219+omarismail94@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2183
Description
SyncJobStatus.StartedandSyncJobStatus.Finishedobjects as opposed to being instantiated each timeFhirSynchronizer.syncStateproperty that a caller can listen to without having to tellFhirSynchronizerAlternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.